Skip to content

fix: build in dependency order, disable gnosis-safe package#34

Merged
MantisClone merged 2 commits intomasterfrom
33-build-fails
Nov 18, 2022
Merged

fix: build in dependency order, disable gnosis-safe package#34
MantisClone merged 2 commits intomasterfrom
33-build-fails

Conversation

@MantisClone
Copy link
Member

Closes #33

Changes

  • Build packages in dependency order
  • Disable gnosis-safe package. Failing due to error:
> request-gnosis-safe
yarn run v1.22.19
$ NODE_OPTIONS=--max_old_space_size=8192 react-scripts build
Creating an optimized production build...
Failed to compile.

/home/david/projects/request-apps/packages/gnosis-safe/src/components/CreateRequest.tsx
TypeScript error in /home/david/projects/request-apps/packages/gnosis-safe/src/components/CreateRequest.tsx(113,23):
Property 'DaiIcon' does not exist on type 'typeof import("/home/david/projects/request-apps/packages/request-ui/dist/currencies/index")'.  TS2339

    111 |   if (network === 1) {
    112 |     return {
  > 113 |       DAI: currencies.DaiIcon,
        |                       ^
    114 |       ETH: currencies.EthIcon,
    115 |       // USDT: UsdtIcon,
    116 |       USDC: currencies.UsdcIcon,


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: /home/david/.nvm/versions/node/v16.10.0/bin/node
Arguments: /home/david/.nvm/versions/node/v16.10.0/lib/node_modules/yarn/lib/cli.js run build
Directory: /home/david/projects/request-apps/packages/gnosis-safe
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspaces for documentation about this command.

> request-gnosis-safe
yarn run v1.22.19
$ NODE_OPTIONS=--max_old_space_size=8192 react-scripts build
Creating an optimized production build...
Failed to compile.

/home/david/projects/request-apps/packages/gnosis-safe/src/components/CreateRequest.tsx
TypeScript error in /home/david/projects/request-apps/packages/gnosis-safe/src/components/CreateRequest.tsx(113,23):
Property 'DaiIcon' does not exist on type 'typeof import("/home/david/projects/request-apps/packages/request-ui/dist/currencies/index")'.  TS2339

    111 |   if (network === 1) {
    112 |     return {
  > 113 |       DAI: currencies.DaiIcon,
        |                       ^
    114 |       ETH: currencies.EthIcon,
    115 |       // USDT: UsdtIcon,
    116 |       USDC: currencies.UsdcIcon,

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: /home/david/.nvm/versions/node/v16.10.0/bin/node
Arguments: /home/david/.nvm/versions/node/v16.10.0/lib/node_modules/yarn/lib/cli.js run build
Directory: /home/david/projects/request-apps/packages/gnosis-safe
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspaces for documentation about this command.
@MantisClone MantisClone self-assigned this Nov 17, 2022
@MantisClone MantisClone linked an issue Nov 17, 2022 that may be closed by this pull request
@benjlevesque
Copy link
Contributor

FYI the gnosis app is unused afaik

@MantisClone MantisClone merged commit 2800093 into master Nov 18, 2022
@MantisClone MantisClone deleted the 33-build-fails branch November 18, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Build fails

2 participants