fix: build in dependency order, disable gnosis-safe package#34
Merged
MantisClone merged 2 commits intomasterfrom Nov 18, 2022
Merged
fix: build in dependency order, disable gnosis-safe package#34MantisClone merged 2 commits intomasterfrom
MantisClone merged 2 commits intomasterfrom
Conversation
> request-gnosis-safe
yarn run v1.22.19
$ NODE_OPTIONS=--max_old_space_size=8192 react-scripts build
Creating an optimized production build...
Failed to compile.
/home/david/projects/request-apps/packages/gnosis-safe/src/components/CreateRequest.tsx
TypeScript error in /home/david/projects/request-apps/packages/gnosis-safe/src/components/CreateRequest.tsx(113,23):
Property 'DaiIcon' does not exist on type 'typeof import("/home/david/projects/request-apps/packages/request-ui/dist/currencies/index")'. TS2339
111 | if (network === 1) {
112 | return {
> 113 | DAI: currencies.DaiIcon,
| ^
114 | ETH: currencies.EthIcon,
115 | // USDT: UsdtIcon,
116 | USDC: currencies.UsdcIcon,
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: /home/david/.nvm/versions/node/v16.10.0/bin/node
Arguments: /home/david/.nvm/versions/node/v16.10.0/lib/node_modules/yarn/lib/cli.js run build
Directory: /home/david/projects/request-apps/packages/gnosis-safe
Output:
info Visit https://yarnpkg.com/en/docs/cli/workspaces for documentation about this command.
Closed
benjlevesque
approved these changes
Nov 18, 2022
Contributor
|
FYI the gnosis app is unused afaik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Changes
gnosis-safepackage. Failing due to error: