fix: improve hover text 'unknown' for better UX.#47
Merged
MantisClone merged 4 commits intoRequestNetwork:masterfrom Jan 16, 2023
PijiDev:master
Merged
fix: improve hover text 'unknown' for better UX.#47MantisClone merged 4 commits intoRequestNetwork:masterfrom PijiDev:master
MantisClone merged 4 commits intoRequestNetwork:masterfrom
PijiDev:master
Conversation
MantisClone
changed the title
MantisClone
requested changes
Jan 2, 2023
Contributor
Author
|
The build now works, for now I kept the |
MantisClone
requested changes
Jan 15, 2023
Member
MantisClone
left a comment
MantisClone
left a comment
There was a problem hiding this comment.
Thanks for taking a second look at this. I like that you changed the state name from unknown to waiting. However, I think the hover text can still be improved.
MantisClone
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38