fix: remove unnecessary async

[aimensahnoun]

• PrepareRequest method had an async that it should not have, which causes errors when trying to create a request.

Summary by CodeRabbit

• New Features

  • Updated version to 0.1.2 for improved package management.

• Bug Fixes

  • Changed prepareRequest function from asynchronous to synchronous, enhancing its execution flow.

These changes may affect how users interact with request preparation, ensuring smoother integration with other operations.

[coderabbitai]

Walkthrough

This pull request includes two primary changes: an update to the version field in the package.json file from "0.1.1" to "0.1.2", and a modification of the prepareRequest function in src/methods/index.ts, changing its signature from asynchronous to synchronous. The internal logic of the prepareRequest function remains unchanged, while other functions in the same file continue to operate asynchronously.

Changes

File	Change Summary
package.json	Updated version from "0.1.1" to "0.1.2".
src/methods/index.ts	Changed prepareRequest from async function to function; no changes to internal logic.

Possibly related PRs

• chore: upgrade CLI version #8: The version field in package.json was updated from "0.1.0" to "0.1.1", which is related to the version update from "0.1.1" to "0.1.2" in the main PR.

Suggested reviewers

• rodrigopavezi
• sstefdev
• MantisClone

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/methods/index.ts (1)

Line range hint 1-54: Correct removal of unnecessary async modifier!

The change to remove the async modifier is appropriate since the function performs only synchronous operations (object construction) and doesn't contain any await statements or Promise returns.

Consider adding TypeScript types for better type safety

While the implementation is correct, consider enhancing type safety by:

1. Using explicit TypeScript types instead of inline interface
2. Adding validation for the currency type

interface PrepareRequestParams {
  currency: Currency;
  payerAddress: string;
  payeeAddress: string;
  amount: string;
  invoiceDetails: IContentData;
}

interface RequestResult {
  requestInfo: RequestInfo;
  paymentNetwork: PaymentNetwork;
  contentData: ContentData;
  signer: Signer;
}

export function prepareRequest(params: PrepareRequestParams): RequestResult {
  // ... existing implementation
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 705e420 and 3ec2e45.

📒 Files selected for processing (2)

• package.json (1 hunks)
• src/methods/index.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• package.json

🔇 Additional comments (1)

src/methods/index.ts (1)

1-1: Verify integration with async methods

While the sync to async change is correct, please ensure that integration tests cover the interaction between prepareRequest and async methods like createRequest to verify the change doesn't affect the request creation flow.