Skip to content

feat: Pay before Persist experiment #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MantisClone merged 1 commit into from
Mar 29, 2024
Merged

feat: Pay before Persist experiment #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/request-client.js/src/api/request-network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export default class RequestNetwork {
public paymentNetworkFactory: PaymentNetworkFactory;
public supportedIdentities: IdentityTypes.TYPE[] = supportedIdentities;

private requestLogic: RequestLogicTypes.IRequestLogic;
private transaction: TransactionTypes.ITransactionManager;
public requestLogic: RequestLogicTypes.IRequestLogic;
public transaction: TransactionTypes.ITransactionManager;
private advancedLogic: AdvancedLogicTypes.IAdvancedLogic;

private contentData: ContentDataExtension;
Expand Down Expand Up @@ -374,7 +374,7 @@ export default class RequestNetwork {
* @param parameters Parameters to create a request
* @returns the parameters, ready for request creation, the topics, and the paymentNetwork
*/
private async prepareRequestParameters(parameters: Types.ICreateRequestParameters): Promise<{
public async prepareRequestParameters(parameters: Types.ICreateRequestParameters): Promise<{
requestParameters: RequestLogicTypes.ICreateParameters;
topics: any[];
paymentNetwork: PaymentTypes.IPaymentNetwork | null;
Expand Down
4 changes: 2 additions & 2 deletions packages/request-logic/src/request-logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ export default class RequestLogic implements RequestLogicTypes.IRequestLogic {
*
* @returns the request id, the action and the hashed topics
*/
private async createCreationActionRequestIdAndTopics(
public async createCreationActionRequestIdAndTopics(
requestParameters: RequestLogicTypes.ICreateParameters,
signerIdentity: IdentityTypes.IIdentity,
topics: any[],
Expand Down Expand Up @@ -665,7 +665,7 @@ export default class RequestLogic implements RequestLogicTypes.IRequestLogic {
*
* @returns void, throws if the action is invalid
*/
private async validateAction(
public async validateAction(
requestId: RequestLogicTypes.RequestId,
action: RequestLogicTypes.IAction,
): Promise<void> {
Expand Down