fix: invalid decimal places for fUSDT and fUSDC on sepolia#1422
Merged
MantisClone merged 2 commits intoRequestNetwork:masterfrom Jul 1, 2024
Merged
fix: invalid decimal places for fUSDT and fUSDC on sepolia#1422MantisClone merged 2 commits intoRequestNetwork:masterfrom
MantisClone merged 2 commits intoRequestNetwork:masterfrom
Conversation
github-actions
bot
requested review from
alexandre-abrioux,
kevindavee,
leoslr and
sstefdev
MantisClone
approved these changes
Jun 29, 2024
Member
|
Merging with 1 review to unblock Request Network Summer Hackathon hacker (Discord user: envoy_) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Fixed Invalid Decimal Places on
fUSDCandfUSDTon sepolia. Initially it was18by according to smart contracts on sepolia it is6which can cause invalidexpectedAmountif one parses units with these Decimals.https://sepolia.etherscan.io/address/0xF046b3CA5ae2879c6bAcC4D42fAF363eE8379F78#readContract
https://sepolia.etherscan.io/address/0x1c7D4B196Cb0C7B01d743Fbc6116a902379C7238#readProxyContract