fix: assert promise is rejected and error is thrown after last retry

[MantisClone]

Follow-up #1316

Description of the changes

• fix: assert promise is rejected and error is thrown after last retry

Summary by CodeRabbit

• Tests
  • Enhanced test suite for the retry mechanism with new assertions for error handling after retries.
  • Improved validation of the retry logic, ensuring correct behavior with exponential backoff.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the test suite for the retry function in packages/utils/test/retry.test.ts. A new assertion has been added to ensure that the function correctly rejects a promise with the expected error message after all retry attempts have been exhausted. Additionally, a previously existing line that checked for this rejection has been removed, streamlining the test verification process. Overall, the test structure remains unchanged aside from these modifications.

Changes

File Path	Change Summary
packages/utils/test/retry.test.ts	Added a new assertion to verify promise rejection after the last retry with exponential backoff; removed redundant rejection check.

Possibly related PRs

• fix: improve error message when persistTransaction times out. Increase default timeout to 130 seconds using Exponential Backoff #1316: The changes in this PR involve modifications to the retry logic and exponential backoff strategy, which directly relate to the enhancements made in the main PR's test suite for the retry function, particularly in how retries and delays are handled.

Suggested reviewers

• alexandre-abrioux
• kevindavee
• yomarion
• sstefdev
• rodrigopavezi
• aimensahnoun

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between b2019da and 8c5cbc1.

📒 Files selected for processing (1)

• packages/utils/test/retry.test.ts (1 hunks)

🧰 Additional context used

📓 Learnings (2)

📓 Common learnings

Learnt from: MantisClone
PR: RequestNetwork/requestNetwork#1316
File: packages/utils/test/retry.test.ts:149-216
Timestamp: 2024-10-02T05:15:18.868Z
Learning: Developers prefer unrolled loops and explicit comments in test code, particularly in 'retry.test.ts' for the exponential backoff test, to show the number of calls and total elapsed time for retries, rather than refactoring using loops.

packages/utils/test/retry.test.ts (1)

Learnt from: MantisClone
PR: RequestNetwork/requestNetwork#1316
File: packages/utils/test/retry.test.ts:149-216
Timestamp: 2024-10-02T05:15:18.868Z
Learning: Developers prefer unrolled loops and explicit comments in test code, particularly in 'retry.test.ts' for the exponential backoff test, to show the number of calls and total elapsed time for retries, rather than refactoring using loops.

🔇 Additional comments (1)

packages/utils/test/retry.test.ts (1)

210-212: Excellent addition to verify final promise rejection!

This new assertion effectively completes the test case by verifying that the promise is indeed rejected after all retry attempts are exhausted. It aligns perfectly with the PR objective of ensuring correct error handling after the last retry.

The test now comprehensively covers the entire retry cycle, including:

1. The initial call
2. All retry attempts with exponential backoff
3. The final rejection when retries are exhausted

This addition enhances the robustness of the test suite and provides explicit verification of the error handling mechanism.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rodrigopavezi]

looks good 👍