chore(eth-fee-proxy-pn): update supported networks#943
chore(eth-fee-proxy-pn): update supported networks#943alexandre-abrioux wants to merge 1 commit intomasterfrom
Conversation
| extensionId: ExtensionTypes.ID = ExtensionTypes.ID.PAYMENT_NETWORK_ETH_FEE_PROXY_CONTRACT, | ||
| currentVersion: string = CURRENT_VERSION, | ||
| public supportedNetworks: string[] = ['mainnet', 'rinkeby', 'goerli', 'private'], | ||
| public supportedNetworks: string[] = [ |
There was a problem hiding this comment.
Is it still relevant? Or shouldn't we map some kind of EVM-compatible pn?
There was a problem hiding this comment.
I wondered why we did not compute this directly from the artifacts, since we have the CURRENT_VERSION constant in the PN could we just check that the contract is deployed for this version and that would be good enough?
There was a problem hiding this comment.
It's not obvious, but it could be a way. The underlying question is: should we constrain library users and prevent the creation of requests that cannot be paid? I think that a warn could be enough.
There was a problem hiding this comment.
I agree, better not to couple it. I tried this instead: #945
| public supportedNetworks: string[] = ['mainnet', 'rinkeby', 'goerli', 'private'], | ||
| public supportedNetworks: string[] = [ | ||
| 'private', | ||
| 'rinkeby', |
There was a problem hiding this comment.
As we have migrated to Goerli, do we still need Rinkeby for legacy purposes?
6 participants
No description provided.