fix: Expected Amount Display for Unknown Currencies in Invoice Dashboard

[sstefdev]

Fixes #268

Problem

The Invoice Dashboard currently defaults to using 18 decimals to display the Expected Amount for currencies that are unknown and not included in the supported currencies list. This behavior can lead to incorrect and misleading data being displayed.

Changes

• Adjusted the calculation logic to prevent incorrect amounts for unsupported currencies.
• Displayed "Unknown" when the currency decimals cannot be determined.
• Provided additional user guidance with a tooltip for unsupported currencies

Invoice Dashboard:

Invoice View:

Summary by CodeRabbit

• New Features

  • Enhanced handling of unknown currencies in the invoice view, improving user feedback on payment statuses.
  • Introduced tooltips for amounts that cannot be calculated due to unknown currency decimals.

• Bug Fixes

  • Improved clarity in displaying payment information when dealing with unsupported currencies.

• Refactor

  • Enhanced readability of wallet connection handling and amount formatting logic.

[coderabbitai]

Walkthrough

The pull request focuses on improving the handling of unknown currencies in the Invoice Dashboard. Changes are made to invoice-view.svelte and view-requests.svelte to address issues with displaying amounts and payment information when the currency's decimals are not defined. The modifications introduce a new unknownCurrency variable, update conditional rendering to show "Unknown" for unrecognized currencies, and enhance user feedback by adding tooltips and preventing incorrect amount calculations.

Changes

File	Change Summary
packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte	- Added unknownCurrency variable - Updated conditional checks for payment network and currency details - Refined balance check logic - Conditionally display "Unknown" for unit prices and total amounts
packages/invoice-dashboard/src/lib/view-requests.svelte	- Reformatted handleWalletChange and onChange functions - Introduced conditional formattedAmount calculation - Added tooltip for amounts with unknown decimals

Assessment against linked issues

Objective	Addressed	Explanation
Display "Unknown" for Expected Amount	✅
Add tooltip for unknown decimals	✅
Re-enable default currency list	❌	Requires additional implementation

Possibly related issues

• Invoice Dashboard displays incorrect amount when token is unknown and has less than 18 decimals #108: Addresses similar concerns about displaying incorrect amounts for unknown tokens, which aligns with the current PR's improvements in handling unknown currencies.

Possibly related PRs

• chore: Update Readme & Unknown Currency Name Fix #263: Addresses unknown currency names, relevant to the current changes
• fix: currency selection issues #280: Improves currency selection and error handling
• fix: balance format issue #281: Modifies balance formatting logic

Suggested reviewers

• MantisClone
• rodrigopavezi

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa6f216 and 53fce1d.

📒 Files selected for processing (2)

• packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte (6 hunks)
• packages/invoice-dashboard/src/lib/view-requests.svelte (5 hunks)

👮 Files not reviewed due to content moderation or server errors (2)

• packages/invoice-dashboard/src/lib/view-requests.svelte
• packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.