-
Notifications
You must be signed in to change notification settings - Fork 45
Attached detached lite #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attached detached lite #390
Conversation
…d/detached definitons
Co-authored-by: Simone Leo <simone.leo@gmail.com>
Co-authored-by: Simone Leo <simone.leo@gmail.com>
… into attached-detached-lite Just updating
elichad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @ptsefton . I found a couple more comments, and there are still some of my previous comments waiting to be addressed.
Co-authored-by: Eli Chadwick <eli.chadwick@manchester.ac.uk>
Co-authored-by: Eli Chadwick <eli.chadwick@manchester.ac.uk>
Co-authored-by: Eli Chadwick <eli.chadwick@manchester.ac.uk>
Co-authored-by: Eli Chadwick <eli.chadwick@manchester.ac.uk>
Co-authored-by: Eli Chadwick <eli.chadwick@manchester.ac.uk>
Co-authored-by: Eli Chadwick <eli.chadwick@manchester.ac.uk>
Co-authored-by: Eli Chadwick <eli.chadwick@manchester.ac.uk>
I think the final summary is correct but kind of backwards. It should not be up to validation software or libraries to divine the type of a crate from what it sees, rather you would process it in Attached or Detached mode depending on the context and report any errors. I think this is clear from the section on Attached and Detached RO-Crate Packages - are you calling it with a path to a directory or to a file/API? |
…es\#r1930927298, removed the third option and added further explanation about processing context
elichad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this now. I'll make a couple of commits to fix the CI and some typos I spotted on my final look through, then merge
This is another approach to clarifying Attached vs Detached that does not introduce much new terminology or conformsTo etc. Again, this is a first pass to see if this approach makes sense, it will need checking.
I moved a bit of stuff around in structure.md but there are no major changes there except to cover how to deal with a Detached RO-Crate Package. Also, did not try to deal with how you'd link one to a website.
In the section on Data Entites i further tidied up the logic around
@ids and contentUrls -- I think this has made it clearer, and I don't think it will be hard to implement.Thanks for your feedback @simleo about the complexity in my last try.