Skip to content

Fix context extra terms #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simleo merged 1 commit into from
Mar 23, 2023
Merged

Fix context extra terms #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runcrate/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
PROVENANCE_PROFILE = f"{PROVENANCE_PROFILE_BASE}/{PROFILES_VERSION}"

TERMS_NAMESPACE = "https://w3id.org/ro/terms/workflow-run"
EXTRA_TERMS = {t: f"{TERMS_NAMESPACE}#t" for t in [
EXTRA_TERMS = {t: f"{TERMS_NAMESPACE}#{t}" for t in [
"ParameterConnection",
"connection",
"sourceParameter",
Expand Down
16 changes: 16 additions & 0 deletions tests/test_cwlprov_crate_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import json

from rocrate.rocrate import ROCrate

from runcrate.convert import ProvCrateBuilder
Expand Down Expand Up @@ -153,6 +155,20 @@ def test_revsort(data_dir, tmpdir):
assert set(profiles) <= set(crate.root_dataset["conformsTo"])
assert set(_.type for _ in profiles) == {"CreativeWork"}
assert [_["version"] for _ in profiles] == ["0.1", "0.1", "0.1", "1.0"]
# extra terms
with open(output / "ro-crate-metadata.json") as f:
metadata = json.load(f)
context = metadata['@context']
context_extensions = [_ for _ in context if isinstance(_, dict)]
assert len(context_extensions) == 1
extra_terms = context_extensions[0]
assert extra_terms == {
"ParameterConnection": "https://w3id.org/ro/terms/workflow-run#ParameterConnection",
"connection": "https://w3id.org/ro/terms/workflow-run#connection",
"sha1": "https://w3id.org/ro/terms/workflow-run#sha1",
"sourceParameter": "https://w3id.org/ro/terms/workflow-run#sourceParameter",
"targetParameter": "https://w3id.org/ro/terms/workflow-run#targetParameter"
}


def test_no_input(data_dir, tmpdir):
Expand Down