Skip to content

Conversation

@simleo
Copy link
Collaborator

@simleo simleo commented May 10, 2023

Adds support for file / directory list PropertyValue instances in the run module. E.g.:

        {
            "@id": "#pv-main/dir_array",
            "@type": "PropertyValue",
            "exampleOfWork": {
                "@id": "packed.cwl#main/dir_array"
            },
            "name": "dir_array",
            "value": [
                {
                    "@id": "cb43436e1eb9f91dd954daff992dc6b852ddc3ee/"
                },
                {
                    "@id": "3c079cbf09e3c7181680f7be7d676acb3ec3403d/"
                }
            ]
        },
        {
            "@id": "cb43436e1eb9f91dd954daff992dc6b852ddc3ee/",
            "@type": "Dataset",
        ...
        }

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 98.18% and project coverage change: +1.44 🎉

Comparison is base (a728698) 95.53% compared to head (c8424c3) 96.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   95.53%   96.97%   +1.44%     
==========================================
  Files          11       11              
  Lines        1566     1619      +53     
==========================================
+ Hits         1496     1570      +74     
+ Misses         70       49      -21     
Impacted Files Coverage Δ
src/runcrate/run.py 80.95% <88.88%> (+13.87%) ⬆️
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_cwlprov_crate_builder.py 99.85% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simleo simleo marked this pull request as ready for review May 10, 2023 09:58
@simleo simleo merged commit ab5eab0 into ResearchObject:main May 10, 2023
@simleo simleo deleted the fix_run_data_entity_list_pv branch May 10, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant