Skip to content

Conversation

@simleo
Copy link
Collaborator

@simleo simleo commented May 18, 2023

Fixes #30.

Handles the situation where a step's input source is an array. For instance, when an array input is fed by multiple scalar outputs from previous steps.

Note that the RO provided in #30 will still fail to convert because ExpressionTool is not supported yet.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (97e68e6) 97.05% compared to head (a0b9378) 97.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   97.05%   97.13%   +0.08%     
==========================================
  Files          11       11              
  Lines        1662     1711      +49     
==========================================
+ Hits         1613     1662      +49     
  Misses         49       49              
Impacted Files Coverage Δ
src/runcrate/convert.py 97.54% <100.00%> (+0.01%) ⬆️
tests/test_cwlprov_crate_builder.py 99.86% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simleo simleo merged commit 5d481fc into ResearchObject:main May 18, 2023
@simleo simleo deleted the handle_multi_source branch May 18, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert CWLProv to RO - TypeError: unhashable type: 'list'

1 participant