Skip to content

Conversation

@simleo
Copy link
Collaborator

@simleo simleo commented May 23, 2023

Fixes #32.

Without this PR, convert_cwl_type could not convert arrays of enums.

The sample RO bundle given in #32 still does not convert because ExpressionTool is not supported yet.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5d481fc) 97.13% compared to head (66a6afc) 97.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   97.13%   97.14%           
=======================================
  Files          11       11           
  Lines        1711     1716    +5     
=======================================
+ Hits         1662     1667    +5     
  Misses         49       49           
Impacted Files Coverage Δ
src/runcrate/convert.py 97.54% <100.00%> (ø)
tests/test_cwlprov_crate_builder.py 99.86% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simleo simleo merged commit 1967e0b into main May 23, 2023
@simleo simleo deleted the fix_convert_cwl_type branch May 23, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError: <cwl_utils.parser.cwl_v1_2.CommandInputEnumSchema object at 0x10aa191e0> ?

2 participants