Skip to content

Fix patch to work on Java 8 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AterAnimAvis merged 1 commit into from
May 21, 2021
Merged

Fix patch to work on Java 8 #11

AterAnimAvis merged 1 commit into from
May 21, 2021

Conversation

@AterAnimAvis
Copy link
Member

@AterAnimAvis AterAnimAvis commented May 19, 2021 

java.io.IOException: Skip failed
    at org.jetbrains.java.decompiler.util.DataInputFullStream.discard(DataInputFullStream.java:52)
    at org.jetbrains.java.decompiler.struct.lazy.LazyLoader.loadBytecode(LazyLoader.java:75)
    at org.jetbrains.java.decompiler.struct.StructMethod.expandData(StructMethod.java:121)
    at org.jetbrains.java.decompiler.main.rels.MethodProcessorRunnable.codeToJava(MethodProcessorRunnable.java:101)
    at org.jetbrains.java.decompiler.main.rels.ClassWrapper.init(ClassWrapper.java:99)
    at org.jetbrains.java.decompiler.main.ClassesProcessor.initWrappers(ClassesProcessor.java:361)
    at org.jetbrains.java.decompiler.main.ClassesProcessor.writeClass(ClassesProcessor.java:307)
    at org.jetbrains.java.decompiler.main.Fernflower.getClassContent(Fernflower.java:100)
    at org.jetbrains.java.decompiler.struct.ContextUnit.save(ContextUnit.java:177)
    at org.jetbrains.java.decompiler.struct.StructContext.saveContext(StructContext.java:77)
    at org.jetbrains.java.decompiler.main.Fernflower.decompileContext(Fernflower.java:67)
    at org.jetbrains.java.decompiler.main.decompiler.ConsoleDecompiler.decompileContext(ConsoleDecompiler.java:171)
    at org.jetbrains.java.decompiler.main.decompiler.ConsoleDecompiler.main(ConsoleDecompiler.java:132)

@AterAnimAvis
fix: Java 8 no longer loading ClassStreams correctly
0789e73 
The original patched will skip the IBytecodeProvider due to the always present byte array (even if it is 0 length), It looks like the original intention is for `link.data` to be null in this case.

Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
@AterAnimAvis AterAnimAvis merged commit fb9e3d5 into Legacy-2.0 May 21, 2021
@AterAnimAvis AterAnimAvis deleted the fix/classpath_loading branch May 23, 2021 18:41
moist-mason pushed a commit to ancientmc/ForgeFlower that referenced this pull request Mar 19, 2023
@AterAnimAvis @moist-mason
fix: Java 8 no longer loading ClassStreams correctly (RetroGradle#11)
c09603a 
The original patched will skip the IBytecodeProvider due to the always present byte array (even if it is 0 length), It looks like the original intention is for `link.data` to be null in this case.

Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
moist-mason pushed a commit to ancientmc/ForgeFlower that referenced this pull request Mar 19, 2023
@AterAnimAvis @moist-mason
fix: Java 8 no longer loading ClassStreams correctly (RetroGradle#11)
20b344d 
The original patched will skip the IBytecodeProvider due to the always present byte array (even if it is 0 length), It looks like the original intention is for `link.data` to be null in this case.

Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
TheCurle pushed a commit that referenced this pull request Mar 22, 2023
@AterAnimAvis @SizableShrimp
fix: Java 8 no longer loading ClassStreams correctly (#11)
06421e8 
The original patched will skip the IBytecodeProvider due to the always present byte array (even if it is 0 length), It looks like the original intention is for `link.data` to be null in this case.

Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
TheCurle pushed a commit that referenced this pull request Mar 22, 2023
@AterAnimAvis @SizableShrimp
fix: Java 8 no longer loading ClassStreams correctly (#11)
46b9118 
The original patched will skip the IBytecodeProvider due to the always present byte array (even if it is 0 length), It looks like the original intention is for `link.data` to be null in this case.

Signed-off-by: AterAnimAvis <AterAnimAvis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AterAnimAvis