Improve docs on creating a simple kernel #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Jan 31, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
No first person form of documentation and remove suggestion for defining entry point before include statements. If anything, inform the readers that if there's any function definitions (such as inline ones) in a header, then it could interfere with the placement of the entry point function at the beginning of the file.
Other than that, it's nice to see more documentation for this!
ghost
approved these changes
Feb 1, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Thanks for the updates, looks good to me!
Member
|
Looks good! |
fengjixuchui
referenced
this pull request
in fengjixuchui/Pure64
Mar 2, 2020
Merge pull request ReturnInfinity#68 from G3bE/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a simple linker script that links the kernel to 1 MiB. Additionally, I suggested a routine to create a bootable image that qemu can run.