Skip to content

Replace signed condtional jumps #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanSeyler merged 1 commit into from
May 2, 2025
Merged

Replace signed condtional jumps #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/init/acpi.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ searchingforACPI:
cmp rax, rbx ; Verify the Signature
je foundACPI
cmp esi, 0x000FFFFF ; Keep looking until we get here
jge noACPI ; ACPI tables couldn't be found, fail
jae noACPI ; ACPI tables couldn't be found, fail
jmp searchingforACPI

; Find the ACPI RSDP Structure on a UEFI system
Expand Down Expand Up @@ -185,7 +185,7 @@ parseAPICTable:

readAPICstructures:
cmp ebx, ecx
jge parseAPICTable_done
jae parseAPICTable_done
lodsb ; APIC Structure Type
cmp al, 0x00 ; Processor Local APIC
je APICapic
Expand Down
2 changes: 1 addition & 1 deletion src/init/hpet.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ init_hpet:

; Verify the Counter Clock Period is valid
cmp eax, 0x05F5E100 ; 100,000,000 femtoseconds is the maximum
jg os_hpet_init_error
ja os_hpet_init_error
cmp eax, 0 ; The Period has to be greater than 1 femtosecond
je os_hpet_init_error

Expand Down
10 changes: 5 additions & 5 deletions src/pure64.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,12 +478,12 @@ uefi_memmap_next:
je uefi_memmap_end
mov rax, [rsi+8]
cmp rax, 0x100000 ; Test if the Physical Address less than 0x100000
jl uefi_memmap_next ; If so, skip it
jb uefi_memmap_next ; If so, skip it
mov rax, [rsi]
cmp rax, 0 ; EfiReservedMemoryType (Not usable)
je uefi_memmap_next
cmp rax, 7 ; EfiConventionalMemory (Free)
jle uefi_memmap_usable
jbe uefi_memmap_usable
mov bl, 0
jmp uefi_memmap_next
uefi_memmap_usable:
Expand Down Expand Up @@ -524,7 +524,7 @@ uefi_purge:
stosq
lodsq
cmp rax, 0x300
jl uefi_purge_remove
jb uefi_purge_remove
stosq
jmp uefi_purge
uefi_purge_remove:
Expand Down Expand Up @@ -666,7 +666,7 @@ pde_next_range:
cmp rax, 0 ; Check if at end of records
je pde_end ; Bail out if so
cmp rax, 0x00200000
jg skipfirst4mb
ja skipfirst4mb
add rax, 0x00200000 ; Add 2 MiB to the base
sub rcx, 2 ; Subtract 2 MiB from the length
skipfirst4mb:
Expand Down Expand Up @@ -788,7 +788,7 @@ lfb_wc_1GB:
mov rax, [0x00005F00] ; Base address of video memory
mov rbx, 0x100000000 ; Compare to 4GB
cmp rax, rbx
jle lfb_wc_end ; If less, don't set WC
jbe lfb_wc_end ; If less, don't set WC
shr rax, 27 ; Quick divide
mov edi, 0x00003000 ; Address of low PDPTEs
add edi, eax ; Add the offset
Expand Down