Skip to content

ActivateAccount renamed to AccountOnboarding#20

Open
CerzBbz wants to merge 2 commits intomasterfrom
hotfix/ActivateAccountFix
Open

ActivateAccount renamed to AccountOnboarding#20
CerzBbz wants to merge 2 commits intomasterfrom
hotfix/ActivateAccountFix

Conversation

@CerzBbz
Copy link
Copy Markdown
Member

@CerzBbz CerzBbz commented Jan 30, 2018

Renamed activate account to onboarding as suggested in pr 12

Brought AccountOnboarding up to date to use a greedy url handler to capture the password hash.

Changed wording of activate account view and email.

@CerzBbz CerzBbz requested a review from acuthbert January 30, 2018 09:31
@CerzBbz
Copy link
Copy Markdown
Member Author

CerzBbz commented Jan 30, 2018

Should the $onboardingChildUrl be changed from 'activate' to 'onboarding'?


class ActivateAccountInvitationEmail extends ResetPasswordInvitationEmail
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave a deprecated version of all of these classes around in case someone was using them

@CerzBbz
Copy link
Copy Markdown
Member Author

CerzBbz commented Feb 2, 2018

"I'd leave a deprecated version of all of these classes around in case someone was using them"
- samnotsowise

Readded old classes having them only extending their replacements with deprecated tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants