Skip to content

feat:implement Distinct operator |test included#30

Merged
Rich-T-kid merged 2 commits intopre-releasefrom
feature/Distinct-Exec
Nov 30, 2025
Merged

feat:implement Distinct operator |test included#30
Rich-T-kid merged 2 commits intopre-releasefrom
feature/Distinct-Exec

Conversation

@Rich-T-kid
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a Distinct operator for the opti-sql-go query engine that filters input data to return only unique row combinations based on specified columns. The implementation follows the existing operator pattern in the codebase but contains several critical bugs related to memory management and resource cleanup that must be addressed before merging.

Key Changes:

  • Adds a new Distinct operator struct with methods implementing the operators.Operator interface
  • Implements a pipeline-breaking approach that consumes all input before returning distinct results
  • Adds comprehensive test coverage including unit tests for the operator and helper functions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 27 comments.

File Description
src/Backend/opti-sql-go/operators/filter/limit.go Implements the Distinct operator with helper functions for array manipulation and deduplication logic
src/Backend/opti-sql-go/operators/filter/limit_test.go Adds test cases for Distinct operator functionality and helper functions including edge cases and resource management tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread src/Backend/opti-sql-go/operators/filter/limit_test.go
Comment thread src/Backend/opti-sql-go/operators/filter/limit_test.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/limit_test.go
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go Outdated
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go
Comment thread src/Backend/opti-sql-go/operators/filter/limit_test.go
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go
Comment thread src/Backend/opti-sql-go/operators/filter/limit.go Outdated
@Rich-T-kid Rich-T-kid merged commit bf24562 into pre-release Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants