feat:implement Distinct operator |test included#30
Merged
Rich-T-kid merged 2 commits intopre-releasefrom Nov 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a Distinct operator for the opti-sql-go query engine that filters input data to return only unique row combinations based on specified columns. The implementation follows the existing operator pattern in the codebase but contains several critical bugs related to memory management and resource cleanup that must be addressed before merging.
Key Changes:
- Adds a new
Distinctoperator struct with methods implementing theoperators.Operatorinterface - Implements a pipeline-breaking approach that consumes all input before returning distinct results
- Adds comprehensive test coverage including unit tests for the operator and helper functions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 27 comments.
| File | Description |
|---|---|
| src/Backend/opti-sql-go/operators/filter/limit.go | Implements the Distinct operator with helper functions for array manipulation and deduplication logic |
| src/Backend/opti-sql-go/operators/filter/limit_test.go | Adds test cases for Distinct operator functionality and helper functions including edge cases and resource management tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.