Feat: Implement garbage collection for s3#49
Merged
Rich-T-kid merged 1 commit intopre-releasefrom Feb 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an S3 “garbage collection” background process to the Substrait execution server, intended to clean up cached/result objects after they expire.
Changes:
- Start a background GC goroutine when the gRPC server starts.
- Add a new
substrait/GC.goloop that reads a Redis list and deletes S3 objects not in the keep-set. - Introduce Redis client dependency and add a
server.redis_portconfig field/default.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Backend/opti-sql-go/substrait/server.go | Starts GC goroutine during server startup. |
| src/Backend/opti-sql-go/substrait/GC.go | Implements Redis-driven S3 object deletion loop. |
| src/Backend/opti-sql-go/config/config.go | Adds RedisPort field and default value. |
| src/Backend/opti-sql-go/go.mod | Adds indirect dependencies for Redis client. |
| src/Backend/opti-sql-go/go.sum | Adds checksums for new indirect dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rich-T-kid
force-pushed
the
garbage-collection-thread
branch
from
9b97828 to
3290029
Compare
Rich-T-kid
added a commit
that referenced
this pull request
Feb 8, 2026
Feat: Implement garbage collection for s3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.