fix(security): expand SSRF hostname blocklist#26
Open
mduongvandinh wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix(security): expand SSRF hostname blocklist#26mduongvandinh wants to merge 1 commit intoRightNow-AI:mainfrom
mduongvandinh wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Add Alibaba Cloud metadata (100.100.100.200), Azure legacy IMDS
(192.0.0.192), IPv6 loopback (::1, [::1]), ip6-localhost, and
0.0.0.0 to the hostname blocklist in check_ssrf().
Fix IPv6 bracketed hostname extraction for URLs like
http://[::1]:8080/ — the old host.split(':') logic extracted "["
instead of "[::1]".
Prevents SSRF attacks targeting additional cloud metadata endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_ssrf()to cover additional cloud metadata endpointshttp://[::1]:8080/)Changes
ip6-localhost,100.100.100.200(Alibaba Cloud),192.0.0.192(Azure IMDS),0.0.0.0,::1,[::1][::1]:portwas extracted as[instead of[::1])ssrf_blocks_alibaba_metadata,ssrf_blocks_ipv6_localhost,ssrf_blocks_zero_ipTest plan
cargo test -p openfang-runtime ssrf)cargo clippy -p openfang-runtime --all-targets -- -D warnings)Files changed
crates/openfang-runtime/src/web_fetch.rs(+33, -2)