This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Handling Cloudfront deletion #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP500
changed the base branch from
master
to
cinq_next_dns_hijack_s3_removal
| case "DeleteDistribution": | ||
| return cf.analyzedeleteDistributionEntries() | ||
| default: | ||
| return &model.HijackableResourceChain{}, nil |
Contributor
There was a problem hiding this comment.
Needs a check here to see if its possible to create a cloud front distribution with an origin that points to a resource that doesnt exist. If this is possible, we need to check for this.
Need to check here to see if it is possible to create a distro that point to a resource that exists but we dont own.
Both cases need to have analysis code.
This may just need to be its own ticket.
HTTP500
changed the base branch from
cinq_next_dns_hijack_s3_removal
to
rename_schema_for_clarity
riot-jetaylor
suggested changes
Oct 6, 2020
| return hijackChain, nil | ||
| } | ||
|
|
||
| func (r *queryResolver) HijackChainByDomain(ctx context.Context, id string, domains []string, typeArg model.Type) (*model.HijackableResourceChain, error) { |
Contributor
There was a problem hiding this comment.
This method should have its params changed.
| PrimaryResource: rawChain.Resource.ID, | ||
| PrimaryAccountId: rawChain.Resource.Account, | ||
| PrimaryResourceType: rawChain.Resource.Type.String(), | ||
| PrimaryResource: root.RootResource.Account, |
Contributor
There was a problem hiding this comment.
Should be resource ID?
riot-jetaylor
approved these changes
Oct 7, 2020
Contributor
riot-jetaylor
left a comment
riot-jetaylor
left a comment
There was a problem hiding this comment.
Looks good @HTTP500
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.