Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #42 +/- ##
============================================
- Coverage 70.22% 60.01% -10.21%
============================================
Files 49 52 +3
Lines 1088 1278 +190
Branches 55 81 +26
============================================
+ Hits 764 767 +3
- Misses 324 511 +187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit adds simple networking functionality built on top of libcurl library. Main implementation focuses on introduction of new (optional) thread (NetThread) that will be used to process networking I/O operations and some simple utilities (`SimpleUrlLoader` class) that can be used to make network requests. For now only simple functionality exists: * Simple fetching via GET/HEAD (single callback when request finishes) * Optionally providing custom headers for the requests * Reading response headers * Specifying timeout details * Reading response timing details This will be expanded in the followup commits.
Fix compilation on ubuntu gcc/clang
Fix compilation on MSVC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds simple networking functionality built on top of libcurl library. Main implementation focuses on introduction of new (optional) thread (NetThread) that will be used to process networking I/O operations and some simple utilities (
SimpleUrlLoaderclass) that can be used to make network requests.For now only simple functionality exists:
This will be expanded in the followup commits.