Conversation
This commit adds #ifdef guards to all headers that are for optional
modules to ensure that code in them is not processed if the module is
not built/installed. At the moment there are no errors, but this may
change in the future.
Furthermore, this commit also adds some convenience helper methods to
`base::net::ResourceRequest` to make it easier to create them.
Previously user had to provide all parameters until the last intended
one (due no designed initializers in C++17). With new methods, users
can start with URL and then add parameters as they see fit. Example:
```cpp
base::net::ResourceRequest{"https://www.google.com/robots.txt"}
.WithHeadersOnly()
.WithTimeout(base::Seconds(5)),
```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #59 +/- ##
===========================================
+ Coverage 58.18% 59.37% +1.18%
===========================================
Files 56 57 +1
Lines 1435 1472 +37
Branches 87 87
===========================================
+ Hits 835 874 +39
+ Misses 600 598 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…uest Add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds #ifdef guards to all headers that are for optional modules to ensure that code in them is not processed if the module is not built/installed. At the moment there are no errors, but this may change in the future.
Furthermore, this commit also adds some convenience helper methods to
base::net::ResourceRequestto make it easier to create them. Previously user had to provide all parameters until the last intended one (due no designed initializers in C++17). With new methods, users can start with URL and then add parameters as they see fit. Example:base::net::ResourceRequest{"https://www.google.com/robots.txt"} .WithHeadersOnly() .WithTimeout(base::Seconds(5)),