change Utils.sha256 and Utils.double_sha256 input type to iodata#14
Merged
Merged
Conversation
…nd sha256 type to iodata
leishman
approved these changes
Jun 25, 2020
SachinMeier
added a commit
that referenced
this pull request
Apr 2, 2025
* add add-field funcs * add specs and global add-field funcs * refactor for code efficiency * finalize add-fields funcs for psbt * temp: fix script vs binary * all PSBT pubkeys -> Point structs * fix credo lint * lint * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:crypto.hash already support iodata. So we should change
Utils.sha256andUtils.double_sha256(renamed it fromUtils.bin_double_sha256) to iodata which is more flexible than just binary so it can also accept likecharlist,iolist.I have also run
mix formatin local. We should integrate Github action to add lint and test to CI .