Bind another keys for up/down navigation in file picker

[soomtong]

HHKB keyboard users like me prefer to navigate using methods other than the arrow keys.
Having used terminal user interface applications for many years, I believe this approach is a more common way to use such programs.
Thank you for creating such a great application.
It’s okay if you reject this PR.

[RivoLink]

Hi @soomtong
Thanks for your interest and PR.

Ctrl+P is already used to open/close the fuzzy picker, so using it for something else might be confusing.
For navigating the file browser, you already have the hidden shortcuts j/k for up/down.

Is that ok for you?

[soomtong]

Oh, sorry. I wasn't able to use the j/k keys in the table navigation. I'll check again with the latest version! Of course, if j/k navigation works, this PR isn't necessary (obviously!).

[soomtong]

This is the process of launching an application and searching for a file.

Since j/k trigger fuzzy search, they can’t function like arrow keys. That’s why people usually use Ctrl+N/P.

I am aware that Ctrl+P opens the file finder modal. I think the Esc key is sufficient for closing the modal.
If a compromise is possible, would it be feasible to provide Ctrl+J/K?

[RivoLink]

Hi @soomtong
Thanks for your update, sorry for my delay.

I have a few suggestions:

• I did a review; could you apply them?
• Could you rebase from main and amend your updates into a single commit?
• The main branch only accepts signed commits, so if you can, I’d appreciate it if you signed the commit. If not, no worries, I’ll sign it myself while preserving you as the author.

GPG signing docs: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Thanks again for your patience.

[soomtong]

No problem. Thank you for giving me the opportunity to contribute. Please review this one more time.

[RivoLink]

Thank you too 🙂
Just run cargo fmt and amend the commit, then it will be perfect.

[RivoLink]

Perfect 💚
Thank you so much.