Added overloads for const std::string& and const char* arguments#258
Merged
RobLoach merged 1 commit intoRobLoach:masterfrom Oct 9, 2023
Bigfoot71:master
Merged
Added overloads for const std::string& and const char* arguments#258RobLoach merged 1 commit intoRobLoach:masterfrom Bigfoot71:master
RobLoach merged 1 commit intoRobLoach:masterfrom
Bigfoot71:master
Conversation
Owner
|
Thanks a lot 👍 ... Could apply to the other ones classes too, but not absolutely needed. |
Contributor
Author
|
I checked just in case, but I don't see any other raylib functions that would have a specific behavior when a null pointer is given rather than a "string". The proposed modification was primarily for this scenario. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily a suggestion, wouldn't adding an overload function
LoadFromMemory(const char* vsCode, const char* fsCode)be more convenient in the case where we might, for example, want to load a fragment shader from memory with the default vertex shader?For the sake of consistency, I've also added one for
static ::Shader Load(...), to see if it would be equally useful.