Changing access modifiers to protected#259
Merged
RobLoach merged 1 commit intoRobLoach:masterfrom Oct 9, 2023
Bigfoot71:master
Merged
Changing access modifiers to protected#259RobLoach merged 1 commit intoRobLoach:masterfrom Bigfoot71:master
protected#259RobLoach merged 1 commit intoRobLoach:masterfrom
Bigfoot71:master
Conversation
Changing access modifiers to `protected` for the `set()` functions
Owner
|
Down with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest changing the access modifier of the member functions
set()fromprivatetoprotectedbecause using this function can be beneficial and avoids casting onthisin cases where one is writing classes that inherit.