update to add setting for fixing a seed before execution of f and g f…#4
Merged
RobinBruegger merged 2 commits intoRobinBruegger:masterfrom Jan 23, 2020
lucidrains:master
Merged
update to add setting for fixing a seed before execution of f and g f…#4RobinBruegger merged 2 commits intoRobinBruegger:masterfrom lucidrains:master
RobinBruegger merged 2 commits intoRobinBruegger:masterfrom
lucidrains:master
Conversation
Owner
|
Thanks again for the PR @lucidrains . I refactored the code a bit. Functionally, it should be unchanged. Otherwise, please let me know. I have created version 0.2.2 with this addition. |
Contributor
Author
|
@RobinBruegger woohoo! thank you! |
|
@RobinBruegger <https://github.com/RobinBruegger> Thanks Robin.
Btw the set_seed(namespace) used in the init seed method might need a
prefix underscore.
…On Thu, Jan 23, 2020, 11:47 PM Phil Wang ***@***.***> wrote:
@RobinBruegger <https://github.com/RobinBruegger> woohoo! thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AID3IGEQKQ4GX6TUSZI7NALQ7IGATA5CNFSM4KK3EVCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJY7BMY#issuecomment-577892531>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AID3IGG43PJC2YHPZSZBM23Q7IGATANCNFSM4KK3EVCA>
.
|
Owner
|
@ag1988 Thanks for reporting that. Turns out I did not turn |
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…unctions
@RobinBruegger @ag1988 Although not elegant, I believe this should fix the problem