Skip to content

feat: inform user about invalid parent directory #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinTheHood merged 4 commits into from
Nov 9, 2020
Merged

feat: inform user about invalid parent directory #60

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89d178d
feat: inform user about invalid parent directory
Nov 5, 2020
e828276
refactor: directory is checked in doSystemCheck()
Nov 5, 2020
20c6c9b
style: show directory in code block
Nov 5, 2020
0f4d258
refactor: directory check with absolute path
Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mmlc_installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public function invokeIndex()
public function doSystemCheck()
{
$errors = [];

if (!ini_get('allow_url_fopen')) {
$errors[] = 'No connection to server. <strong>allow_url_fopen</strong> has to be activated in php.ini.';
}
Expand All @@ -54,6 +55,10 @@ public function doSystemCheck()
$errors[] = 'Current PHP version is ' . PHP_VERSION . '. The MMLC needs version <strong>' . self::REQUIRED_PHP_VERSION . '</strong> or higher.';
}

if (!file_exists(__DIR__ . '/includes/classes/modified_api.php')) {
$errors[] = '<code style="display: inline; padding: 2px 4px;">' . __DIR__ . '</code> is the wrong installation directory. Please use the shop root.';
}

return $errors;
}

Expand Down