refactor: remove sync pipeline API, make entire render chain async#6
Merged
refactor: remove sync pipeline API, make entire render chain async#6
Conversation
Remove TemplatePipeline.Process() and TemplateExpander.Expand() sync methods. All rendering now goes through ProcessAsync/ExpandAsync, fixing ContentElement expansion error "Content element expansion requires async processing". Also eliminates 3-4x redundant template processing in render methods — each async render method now calls ProcessAsync once and passes the pre-processed template through the entire chain. Additional fixes: - Fix missing _defaultRenderOptions in async Render(SKBitmap) overloads - Fix ExprValue.ToString() culture sensitivity (InvariantCulture) - Add regression test for ContentElement through async pipeline - Update 38 files: production code, CLI, and 170+ test methods
RoboNET
added a commit
that referenced
this pull request
Mar 11, 2026
Remove TemplatePipeline.Process() and TemplateExpander.Expand() sync methods. All rendering now goes through ProcessAsync/ExpandAsync, fixing ContentElement expansion error "Content element expansion requires async processing". Also eliminates 3-4x redundant template processing in render methods — each async render method now calls ProcessAsync once and passes the pre-processed template through the entire chain. Additional fixes: - Fix missing _defaultRenderOptions in async Render(SKBitmap) overloads - Fix ExprValue.ToString() culture sensitivity (InvariantCulture) - Add regression test for ContentElement through async pipeline - Update 38 files: production code, CLI, and 170+ test methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove TemplatePipeline.Process() and TemplateExpander.Expand() sync methods. All rendering now goes through ProcessAsync/ExpandAsync, fixing ContentElement expansion error "Content element expansion requires async processing".
Also eliminates 3-4x redundant template processing in render methods — each async render method now calls ProcessAsync once and passes the pre-processed template through the entire chain.
Additional fixes: