feat: add ParameterClient for external parameter access #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmoud-ghalayini
force-pushed
the
feat-add-parameter-client-for-external-parameter-access-1317
branch
from
05728bf to
9cb7abb
Compare
minggangw
reviewed
Nov 1, 2025
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR, will take a look later.
minggangw
approved these changes
Nov 2, 2025
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
Thanks for the PR with effective unit test & ts declaration, LGTM!
mahmoud-ghalayini
force-pushed
the
feat-add-parameter-client-for-external-parameter-access-1317
branch
from
9cb7abb to
14ed2c5
Compare
Member
|
@mahmoud-ghalayini please go ahead to merge the PR, thanks! |
minggangw
approved these changes
Nov 4, 2025
minggangw
pushed a commit
that referenced
this pull request
Nov 26, 2025
Added ParameterClient class for remote parameter access: - node.createParameterClient(remoteNodeName, options) - node.destroyParameterClient(parameterClient) - ParameterClient with full API for get/set/list/describe operations - Exported parameterTypeFromValue utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
Added
ParameterClientclass for remote parameter access:node.createParameterClient(remoteNodeName, options)node.destroyParameterClient(parameterClient)ParameterClientwith full API for get/set/list/describe operationsparameterTypeFromValueutility#1317