Refactor SocketAdapter from mixin pattern to a wrapper#1000
Merged
EzraBrooks merged 1 commit intodevelopfrom Nov 6, 2025
Merged
Refactor SocketAdapter from mixin pattern to a wrapper#1000EzraBrooks merged 1 commit intodevelopfrom
EzraBrooks merged 1 commit intodevelopfrom
Conversation
EzraBrooks
force-pushed
the
refactor-socketadapter
branch
from
b9ca5a8 to
e2a4af0
Compare
EzraBrooks
force-pushed
the
refactor-socketadapter
branch
from
e2a4af0 to
0138360
Compare
This comment was marked as resolved.
This comment was marked as resolved.
EzraBrooks
force-pushed
the
refactor-socketadapter
branch
from
0138360 to
5f45935
Compare
This comment was marked as resolved.
This comment was marked as resolved.
EzraBrooks
force-pushed
the
refactor-socketadapter
branch
from
5f45935 to
6aa2e4e
Compare
bjsowa
reviewed
Nov 6, 2025
I think this is a more sensical approach to this problem. SocketAdapter provides a coherent ROS API on top of either a browser WebSocket, a ws WebSocket, or an RTCDataChannel - it should be written as a wrapper.
EzraBrooks
force-pushed
the
refactor-socketadapter
branch
from
6aa2e4e to
8c9435b
Compare
bjsowa
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a more sensical approach to this problem. SocketAdapter provides a coherent ROS API on top of either a browser WebSocket, a ws WebSocket, or an RTCDataChannel - it should be written as a wrapper.
This technically breaks an API, but only because of Hyrum's Law.. I hope nobody was interacting directly with the
.socketmember ofRos🤦🏻This contains no functional changes, it just changes the scope of some of the socket-handling callbacks to be less confusing.