Update socket.io to 3.0.3#383
Closed
MatthijsBurgh wants to merge 2 commits intoRobotWebTools:developfrom
MatthijsBurgh:patch-1
Closed
Update socket.io to 3.0.3#383MatthijsBurgh wants to merge 2 commits intoRobotWebTools:developfrom MatthijsBurgh:patch-1
MatthijsBurgh wants to merge 2 commits intoRobotWebTools:developfrom
MatthijsBurgh:patch-1
Conversation
mvollrath
approved these changes
Dec 7, 2020
Contributor
Author
|
@mvollrath anything holding this PR to be merged? |
Contributor
Author
|
Please merge #394 in favor of this PR. |
Contributor
Author
|
@mvollrath ping;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a test in my JS app that won't run because of an issue with old
socket.io/engine.io. Moving tosocket.io3.xsolved the issue for me.And never a bad idea to keep up-to-date with your dependencies