Conversation
|
Does the socket.io layer even work? I've asked the question before but I didn't get an answer: #322 |
|
@Rayman I am not sure it works. It isn't tested. But at least I know |
|
I believe the reason why this is left out is because socketio is non-essential and an optional integration whereas the other dependencies are critical to the function of roslib. Socketio is a relatively large library (60kb minified) larger than roslib is currently. So I would keep it as a peer dependency and not require it here. |
|
I am totally fine by making it a peer dependency, but right now it is marked as a normal dependency. Also right now |
|
Why wasn't this already merged? |
|
@francoissunatori see #429 (comment) The question remains if it works and whether it should be included in the compiled libs. If not included a user can always import it him/herself. |
MatthijsBurgh
force-pushed
the
missing_io
branch
from
94ecb43 to
8485a84
Compare
Bumps [mocha](https://github.com/mochajs/mocha) from 9.0.2 to 9.0.3. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](mochajs/mocha@v9.0.2...v9.0.3) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MatthijsBurgh
force-pushed
the
missing_io
branch
from
8485a84 to
46d97e4
Compare
4 participants
No description provided.