Remove Message, ServiceRequest, and ServiceResponse types#691
Merged
Remove Message, ServiceRequest, and ServiceResponse types#691
Conversation
sea-bass
changed the title
sea-bass
commented
Mar 1, 2024
EzraBrooks
approved these changes
Mar 4, 2024
Contributor
EzraBrooks
left a comment
EzraBrooks
left a comment
There was a problem hiding this comment.
As far as I can tell, these were useless and just getting in the way of making typescript types (because you seemingly can't make an interface that extends a non-static type like a generic type argument)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
This gets rid of
ROSLIB.Message,ROSLIB.ServiceRequest, andROSLIB.ServiceResponsesince those data types were simple wrappers that had little value. Now we can use dictionaries as is (or whatever they're called in JavaScript).Description