Fix un-advertisement and multiple-advertisement of Service callbacks#701
Merged
EzraBrooks merged 3 commits intodevelopfrom Mar 20, 2024
Merged
Fix un-advertisement and multiple-advertisement of Service callbacks#701EzraBrooks merged 3 commits intodevelopfrom
EzraBrooks merged 3 commits intodevelopfrom
Conversation
MatthijsBurgh
approved these changes
Mar 20, 2024
Contributor
MatthijsBurgh
left a comment
MatthijsBurgh
left a comment
There was a problem hiding this comment.
Only one comment, for the rest I approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
Calling
Service.advertisemultiple times now throws an error, as suggested in #698.Bugfix: prevent resource leak of Service callbacks
Description
As noted in #698, Service un-advertisement apparently has never removed the callback from the service server, which is probably not good.. for both resource leak reasons and possible unexpected behavior reasons like a callback being invoked even after unadvertisement.