Further modernize class definitions#991
Merged
EzraBrooks merged 2 commits intodevelopfrom Nov 5, 2025
Merged
Conversation
sea-bass
reviewed
Nov 5, 2025
Contributor
sea-bass
left a comment
sea-bass
left a comment
There was a problem hiding this comment.
Looks good, but it's a breaking change, right? Did you intend this to go in before or after the 2.0.0 cutoff?
Contributor
Author
|
I don't think there's any API break here, the signature of the constructors remains the same to customers, it's just destructuring it inline. |
EzraBrooks
force-pushed
the
align-indentation-in-rest-of-app-with-core
branch
from
4b93f21 to
fd5a261
Compare
Base automatically changed from
align-indentation-in-rest-of-app-with-core
to
develop
November 5, 2025 15:31
EzraBrooks
force-pushed
the
modernize-class-definitions
branch
from
15619d7 to
d0cb2c7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
These will be required to move to TypeScript. Also, bonus, it looks like the TypeScript compiler is already able to reasonably infer the types of these thanks to other work we've already done.
EzraBrooks
force-pushed
the
modernize-class-definitions
branch
from
d0cb2c7 to
db22582
Compare
Contributor
Author
|
I plan on incrementally adding JSDoc type annotations to these members in future PRs, thus allowing these files to just be in-place renamed from |
bjsowa
approved these changes
Nov 5, 2025
Member
bjsowa
left a comment
bjsowa
left a comment
There was a problem hiding this comment.
There are still a few formatting changes but I don't see a problem with including them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two major cleanups:
This is not a breaking change, it just changes some syntactic sugar and explicitly declares some things that were previously implicitly declared!