This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Add msg_processing_type field to message action#117
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 60.84% 62.62% +1.77%
==========================================
Files 58 65 +7
Lines 2084 2183 +99
Branches 322 322
==========================================
+ Hits 1268 1367 +99
Misses 816 816
Continue to review full report at Codecov.
|
graywolf336
reviewed
Apr 8, 2019
| @@ -0,0 +1,4 @@ | |||
| export enum MessageProcessingType { | |||
| SendMessage = 'sendMessage', | |||
| RespondWithMessage = 'respondWithMessage', | |||
Contributor
There was a problem hiding this comment.
Wish there was documentation added that said what each of these do. They both seem the same to me :(
Does sendMessage actually send a message without populating the text area for the user to edit beforehand? Or is that respondWithMessage or what?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the field introduced in this PR to the engine.
No further changes are needed on Rocket.Chat for it to work.