Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Licensing strategy#126

Merged
d-gubert merged 14 commits intobetafrom
licensing
Jul 21, 2019
Merged

Licensing strategy#126
d-gubert merged 14 commits intobetafrom
licensing

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jul 1, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #126 into master will decrease coverage by 2.42%.
The diff coverage is 26.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   62.62%   60.19%   -2.43%     
==========================================
  Files          65       60       -5     
  Lines        2183     2123      -60     
  Branches      322      326       +4     
==========================================
- Hits         1367     1278      -89     
- Misses        816      845      +29
Impacted Files Coverage Δ
src/server/compiler/AppFabricationFulfillment.ts 83.33% <20%> (-16.67%) ⬇️
src/server/managers/AppLicenseManager.ts 21.05% <21.05%> (ø)
src/server/misc/Crypto.ts 30.76% <30.76%> (ø)
src/server/AppManager.ts 16.51% <50%> (+0.2%) ⬆️
src/server/errors/index.ts
src/server/accessors/index.ts
src/server/compiler/index.ts
src/server/storage/index.ts
src/server/logging/index.ts
src/server/bridges/index.ts
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ad8ac...12502b6. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #126 into master will decrease coverage by 4.34%.
The diff coverage is 17.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   62.62%   58.27%   -4.35%     
==========================================
  Files          65       62       -3     
  Lines        2183     2217      +34     
  Branches      322      339      +17     
==========================================
- Hits         1367     1292      -75     
- Misses        816      925     +109
Impacted Files Coverage Δ
src/server/ProxiedApp.ts 13.92% <14.28%> (+0.03%) ⬆️
src/server/managers/AppLicenseManager.ts 21.05% <21.05%> (ø)
.../marketplace/license/AppLicenseValidationResult.ts 23.07% <23.07%> (ø)
src/server/marketplace/license/Crypto.ts 25% <25%> (ø)
src/server/compiler/AppFabricationFulfillment.ts 73.33% <27.27%> (-26.67%) ⬇️
src/server/errors/InvalidLicenseError.ts 33.33% <33.33%> (ø)
src/server/AppManager.ts 15.23% <4.76%> (-1.08%) ⬇️
src/server/accessors/index.ts
src/server/compiler/index.ts
src/server/storage/index.ts
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ad8ac...d43014d. Read the comment docs.

@d-gubert d-gubert changed the base branch from master to beta July 21, 2019 00:45
@d-gubert d-gubert marked this pull request as ready for review July 21, 2019 00:54
@d-gubert d-gubert merged commit a349887 into beta Jul 21, 2019
@rodrigok rodrigok deleted the licensing branch July 21, 2019 01:25
@d-gubert d-gubert restored the licensing branch July 30, 2019 03:31
@d-gubert d-gubert deleted the licensing branch July 30, 2019 03:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants