This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[WIP] Redesign webhooks#158
Merged
d-gubert merged 12 commits intoRocketChat:redesign-webhooksfrom Oct 24, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## alpha #158 +/- ##
==========================================
+ Coverage 57.67% 59.09% +1.41%
==========================================
Files 65 73 +8
Lines 2266 2403 +137
Branches 350 356 +6
==========================================
+ Hits 1307 1420 +113
- Misses 959 983 +24
Continue to review full report at Codecov.
|
Contributor
Author
|
@graywolf336 @d-gubert Should we implement Love to hear your opinions on this 😃 |
shiqimei
force-pushed
the
redesign-webhooks
branch
from
a85c6f6 to
9efa64b
Compare
* Remove IWebHooks * Remove webhooks options from IExternalComponentOptions and redesign it Introduce state for external components Add IPreExternalComponentOpenedPrevent handler Add IPostExternalComponentOpened handler * add accessors for IPreExternalComponentOpenedPrevent handler * Add IPostExternalComponentOpened handler Add IPostExternalComponentClosed handler Remove IPreExternalComponentOpenedPrevent
shiqimei
force-pushed
the
redesign-webhooks
branch
from
7c8e13c to
00fdd2f
Compare
* Remove IWebHooks * Remove webhooks options from IExternalComponentOptions and redesign it Introduce state for external components Add IPreExternalComponentOpenedPrevent handler Add IPostExternalComponentOpened handler * add accessors for IPreExternalComponentOpenedPrevent handler * Add IPostExternalComponentOpened handler Add IPostExternalComponentClosed handler Remove IPreExternalComponentOpenedPrevent
…ps-engine into redesign-webhooks
Contributor
Author
|
This PR depends on #165 and RocketChat/Rocket.Chat#15618. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154