This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[FIX] Revert breaking changes on IUser definition#208
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## beta #208 +/- ##
=========================================
- Coverage 56.86% 54.9% -1.96%
=========================================
Files 77 69 -8
Lines 2608 2495 -113
Branches 369 369
=========================================
- Hits 1483 1370 -113
Misses 1125 1125Continue to review full report at Codecov.
|
rodrigok
approved these changes
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
We messed up the IUser definition while finishing app user feature. This PR tries to revert all changes on it and only add an optional
appIdproperty on it.Why? 🤔
Avoid breaking changes and we already achieved the goal with
Partical<IUser>.Links 🌎
N/A
PS 👀
N/A