Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Add new API getAppUserUsername#214

Merged
d-gubert merged 1 commit intobetafrom
add-new-api-getAppUserName
Feb 6, 2020
Merged

Add new API getAppUserUsername#214
d-gubert merged 1 commit intobetafrom
add-new-api-getAppUserName

Conversation

@shiqimei
Copy link
Contributor

@shiqimei shiqimei commented Feb 5, 2020

What? ⛵

Added a new API getAppUserUsername so that apps developver can call this.getAppUserUsername() to get the username of the app user directly.

Why? 🤔

Avoid duplication

Links 🌎

2713ef1#commitcomment-37053956

PS 👀

Priority: moderate

@shiqimei shiqimei requested a review from d-gubert February 5, 2020 05:22
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #214 into beta will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #214      +/-   ##
==========================================
- Coverage   55.89%   55.85%   -0.05%     
==========================================
  Files          78       78              
  Lines        2678     2680       +2     
  Branches      380      380              
==========================================
  Hits         1497     1497              
- Misses       1181     1183       +2
Impacted Files Coverage Δ
src/server/AppManager.ts 14.28% <ø> (ø) ⬆️
src/server/ProxiedApp.ts 13.75% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2924e30...bedbb62. Read the comment docs.

@d-gubert d-gubert merged commit 8d8d51c into beta Feb 6, 2020
@d-gubert d-gubert deleted the add-new-api-getAppUserName branch February 6, 2020 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants