Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Fix modal update#216

Merged
ggazzo merged 1 commit intobetafrom
fix-modal-update
Feb 6, 2020
Merged

Fix modal update#216
ggazzo merged 1 commit intobetafrom
fix-modal-update

Conversation

@sampaiodiego
Copy link
Member

What? ⛵

Fix modal property

Why? 🤔

The previous value was wrong

Links 🌎

PS 👀

@sampaiodiego sampaiodiego requested a review from d-gubert February 6, 2020 02:23
@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #216 into beta will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #216   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          70       70           
  Lines        2566     2566           
  Branches      380      380           
=======================================
  Hits         1382     1382           
  Misses       1184     1184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4ff13...a7a0905. Read the comment docs.

@ggazzo ggazzo merged commit 29567ea into beta Feb 6, 2020
@ggazzo ggazzo deleted the fix-modal-update branch February 6, 2020 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants