Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

[NEW] Add UIKitContextualBar#236

Closed
shiqimei wants to merge 3 commits intoalphafrom
uikit-room-contextual-bar
Closed

[NEW] Add UIKitContextualBar#236
shiqimei wants to merge 3 commits intoalphafrom
uikit-room-contextual-bar

Conversation

@shiqimei
Copy link
Contributor

@shiqimei shiqimei commented Mar 12, 2020

What? ⛵

  • Added UIKitContextualBar
  • Added Unit tests

Why? 🤔

Provides UIKit more abilities to control contextual bar in RocketChat

Links 🌎

Enable Apps to open the room's contextual bar

PS 👀

Medium-low

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #236 into alpha will decrease coverage by 0.05%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #236      +/-   ##
==========================================
- Coverage   55.02%   54.96%   -0.06%     
==========================================
  Files          82       82              
  Lines        2866     2869       +3     
  Branches      406      406              
==========================================
  Hits         1577     1577              
- Misses       1289     1292       +3     
Impacted Files Coverage Δ
src/server/accessors/UIController.ts 33.33% <40.00%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2df37...a3d6fa5. Read the comment docs.

@d-gubert d-gubert force-pushed the uikit-room-contextual-bar branch from f131a59 to a3d6fa5 Compare April 26, 2020 20:30
@d-gubert d-gubert changed the base branch from master to alpha April 26, 2020 20:31
@d-gubert
Copy link
Member

Closing this as it was done in #447

@d-gubert d-gubert closed this Jan 13, 2022
@d-gubert d-gubert deleted the uikit-room-contextual-bar branch May 2, 2024 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants