Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

new User join Event#242

Closed
ggazzo wants to merge 3 commits intoalphafrom
feat/user-join
Closed

new User join Event#242
ggazzo wants to merge 3 commits intoalphafrom
feat/user-join

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 21, 2020

What? ⛵

Why? 🤔

Links 🌎

PS 👀

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #242 into master will decrease coverage by 0.52%.
The diff coverage is 11.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   53.81%   53.28%   -0.53%     
==========================================
  Files          70       71       +1     
  Lines        2568     2601      +33     
  Branches      380      387       +7     
==========================================
+ Hits         1382     1386       +4     
- Misses       1186     1215      +29     
Impacted Files Coverage Δ
src/server/managers/AppListenerManager.ts 4.47% <3.33%> (-0.09%) ⬇️
src/server/users/User.ts 33.33% <33.33%> (ø)
src/server/compiler/AppImplements.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ca98a...5148e04. Read the comment docs.

@d-gubert d-gubert changed the base branch from master to enhancements March 21, 2020 18:36
@d-gubert d-gubert changed the base branch from enhancements to alpha January 4, 2021 19:14
@d-gubert
Copy link
Member

This has been solved in a slightly different way in #266

@d-gubert d-gubert closed this Jan 14, 2021
@graywolf336 graywolf336 deleted the feat/user-join branch January 14, 2021 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants