Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Add field uids to rooms#247

Merged
d-gubert merged 2 commits intobetafrom
add-uids-to-rooms
Mar 25, 2020
Merged

Add field uids to rooms#247
d-gubert merged 2 commits intobetafrom
add-uids-to-rooms

Conversation

@sampaiodiego
Copy link
Member

What? ⛵

Add field uids to rooms

Why? 🤔

New implementation of group DMs will be adding this fields to all direct message rooms.

Links 🌎

PS 👀

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sampaiodiego sampaiodiego requested a review from d-gubert March 25, 2020 20:06
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #247 into beta will increase coverage by 1.93%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             beta   #247      +/-   ##
========================================
+ Coverage   54.06%    56%   +1.93%     
========================================
  Files          72     80       +8     
  Lines        2643   2764     +121     
  Branches      391    391              
========================================
+ Hits         1429   1548     +119     
- Misses       1214   1216       +2
Impacted Files Coverage Δ
src/server/rooms/Room.ts 52.94% <ø> (ø) ⬆️
src/server/accessors/RoomBuilder.ts 97.43% <0%> (-2.57%) ⬇️
src/server/errors/index.ts 100% <0%> (ø)
src/server/managers/index.ts 100% <0%> (ø)
src/server/accessors/index.ts 100% <0%> (ø)
src/server/marketplace/license/index.ts 100% <0%> (ø)
src/server/compiler/index.ts 100% <0%> (ø)
src/server/storage/index.ts 100% <0%> (ø)
src/server/logging/index.ts 100% <0%> (ø)
src/server/bridges/index.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d7a64...9eff79b. Read the comment docs.

@d-gubert d-gubert merged commit 6064a50 into beta Mar 25, 2020
@d-gubert d-gubert deleted the add-uids-to-rooms branch March 25, 2020 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants