Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

Change App’s username pattern to {appName}.bot and prevent duplicated creation#252

Merged
d-gubert merged 1 commit intobetafrom
change-app-username
Mar 30, 2020
Merged

Change App’s username pattern to {appName}.bot and prevent duplicated creation#252
d-gubert merged 1 commit intobetafrom
change-app-username

Conversation

@rodrigok
Copy link
Member

No description provided.

@rodrigok rodrigok requested a review from d-gubert March 29, 2020 22:51
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #252 into master will increase coverage by 1.91%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   53.81%   55.73%   +1.91%     
==========================================
  Files          70       78       +8     
  Lines        2568     2686     +118     
  Branches      380      381       +1     
==========================================
+ Hits         1382     1497     +115     
- Misses       1186     1189       +3     
Impacted Files Coverage Δ
src/server/AppManager.ts 14.17% <0.00%> (-0.11%) ⬇️
src/server/logging/index.ts 100.00% <0.00%> (ø)
src/server/bridges/index.ts 100.00% <0.00%> (ø)
src/server/managers/index.ts 100.00% <0.00%> (ø)
src/server/errors/index.ts 100.00% <0.00%> (ø)
src/server/accessors/index.ts 100.00% <0.00%> (ø)
src/server/compiler/index.ts 100.00% <0.00%> (ø)
src/server/marketplace/license/index.ts 100.00% <0.00%> (ø)
src/server/storage/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ca98a...c5c82ca. Read the comment docs.

@d-gubert d-gubert changed the base branch from master to beta March 30, 2020 00:23
@d-gubert d-gubert merged commit fd1e505 into beta Mar 30, 2020
@d-gubert d-gubert deleted the change-app-username branch March 30, 2020 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants