Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Comments

[NEW] User update#253

Merged
d-gubert merged 1 commit intobetafrom
user-update
Mar 30, 2020
Merged

[NEW] User update#253
d-gubert merged 1 commit intobetafrom
user-update

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Mar 30, 2020

What? ⛵

Introduces methods that allow apps to update some user properties

Why? 🤔

Expanding the framework's API

Links 🌎

PS 👀

Rocket.Chat side implementation RocketChat/Rocket.Chat#17077

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2020

CLA assistant check
All committers have signed the CLA.

@d-gubert d-gubert changed the base branch from master to beta March 30, 2020 02:37
@d-gubert d-gubert requested a review from rodrigok March 30, 2020 02:38
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #253 into beta will decrease coverage by 0.09%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             beta     #253     +/-   ##
=========================================
- Coverage   54.02%   53.93%   -0.1%     
=========================================
  Files          72       73      +1     
  Lines        2645     2657     +12     
  Branches      391      391             
=========================================
+ Hits         1429     1433      +4     
- Misses       1216     1224      +8
Impacted Files Coverage Δ
src/server/accessors/UserUpdater.ts 25% <25%> (ø)
src/server/accessors/ModifyUpdater.ts 91.83% <50%> (-3.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6064a50...f1ab0c4. Read the comment docs.

@d-gubert d-gubert merged commit cd2e502 into beta Mar 30, 2020
@d-gubert d-gubert deleted the user-update branch March 30, 2020 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants