This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[NEW] Enable require of some native modules and global functions#441
Merged
thassiov merged 5 commits intofeat/configure-source-storage-by-settingfrom Sep 23, 2021
Merged
Conversation
Contributor
Author
|
tester app |
d-gubert
changed the title
d-gubert
changed the base branch from
feat/configure-source-storage-by-setting
to
alpha
d-gubert
changed the base branch from
alpha
to
feat/configure-source-storage-by-setting
d-gubert
suggested changes
Sep 6, 2021
graywolf336
approved these changes
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
Allows the app to include code that requires the following modules:
http(requiresnetworkingpermission)https(requiresnetworkingpermission)zlibutilos(as an empty object, only to fulfill some npm dependencies' requirements, as exposing it would lead to security problems)Also, injects the following language features inside the app's context so developers can make use of:
setInterval,setImmediate, etc)BufferWhy? 🤔
As we are allowing external dependencies in apps, some internal functionalities and libs are needed for the apps to function properly.
Links 🌎
PS 👀