This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Create mocks to call accessors from Deno#668
Closed
d-gubert wants to merge 2 commits intofeat/deno-runtimefrom
Closed
Create mocks to call accessors from Deno#668d-gubert wants to merge 2 commits intofeat/deno-runtimefrom
d-gubert wants to merge 2 commits intofeat/deno-runtimefrom
Conversation
Merged
Member
Author
|
Closing in favor of #670 670 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
We need to create accessor mocks in Deno that will call the Node process.
The mocks can be proxies that will issue a Request message to the Node process that will actually perform the method call in the appropriate accessor, returning a Promise that will resolve when Node sends a Response message to the initiating Request.
On the Apps-Engine runtime, this request will be handled by the DenoRuntimeSubprocessController instance associated with the originating subprocess
Why? 🤔
Links 🌎
PS 👀